Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redo presence check after possible reset of user to nil #18462

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Redo presence check after possible reset of user to nil #18462

merged 1 commit into from
Feb 20, 2019

Conversation

d-m-u
Copy link
Contributor

@d-m-u d-m-u commented Feb 18, 2019

Yeah, it's my bug. If the retirement requester was a string and then the lookup for the userid based on that string returned nil, q_options[:user_id] = requester.id will fail cause no id for nil.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1677569.

@d-m-u
Copy link
Contributor Author

d-m-u commented Feb 18, 2019

@miq-bot assign @gmcculloug
@miq-bot add_reviewer @bdunne
@miq-bot add_label hammer/yes, gaprindashvili/yes, bug

@miq-bot miq-bot requested a review from bdunne February 18, 2019 14:00
@miq-bot
Copy link
Member

miq-bot commented Feb 18, 2019

Checked commit d-m-u@df5dca9 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
3 files checked, 0 offenses detected
Everything looks fine. 🍪

@d-m-u
Copy link
Contributor Author

d-m-u commented Feb 20, 2019

any chance someone could please look at this?

@bdunne bdunne merged commit 1680ffb into ManageIQ:master Feb 20, 2019
@bdunne bdunne assigned bdunne and unassigned gmcculloug Feb 20, 2019
@bdunne bdunne added this to the Sprint 106 Ending Mar 4, 2019 milestone Feb 20, 2019
@Fryguy
Copy link
Member

Fryguy commented Feb 20, 2019 •
edited
Loading

@d-m-u @bdunne This PR seems to have broken master post-merge

@d-m-u d-m-u mentioned this pull request Feb 20, 2019
Merged
@d-m-u d-m-u deleted the bz1677569 branch September 26, 2019 10:34
simaishi pushed a commit that referenced this pull request Oct 21, 2019
@bdunne @simaishi
Merge pull request #18462 from d-m-u/bz1677569
074a1c0 
Redo presence check after possible reset of user to nil

(cherry picked from commit 1680ffb)

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1763856
@simaishi
Copy link
Contributor

Hammer backport details:

$ git log -1
commit 074a1c028055aafaf344f48aafa6b5c828052701
Author: Brandon Dunne <[email protected]>
Date:   Wed Feb 20 10:13:54 2019 -0500

    Merge pull request #18462 from d-m-u/bz1677569
    
    Redo presence check after possible reset of user to nil
    
    (cherry picked from commit 1680ffb493068b447a1ffa762b57f7740aee7884)
    
    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1763856

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdunne bdunne Awaiting requested review from bdunne

Assignees

@bdunne bdunne

Labels
bug hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@d-m-u @miq-bot @Fryguy @simaishi @bdunne @gmcculloug